-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PHP_INT_MAX constant #271
Comments
What about loadReverse then? |
The EventStore implementation has to know how to handle With PHP_INT_MAX I am not able to get if a user says "no limit" or "a big number to start". |
prolic
added a commit
that referenced
this issue
Mar 10, 2017
prolic
added a commit
to prooph/pdo-event-store
that referenced
this issue
Mar 10, 2017
ChrisSanderser
added a commit
to ChrisSanderser/event-store
that referenced
this issue
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would prefer to using
null
instead ofPHP_INT_MAX
inload
methods and let decide the implementation how to handle this value. In most cases this value could be ignored in query if it isnull
, if it is not necessary for index usage. Also,PHP_INT_MAX
has a higher memory footprint thannull
. Even it is not always true that PHP and the underlying storage uses the same cpu architecture. (32bit vs. 64bit)I have not investigate much in that issue. Maybe there is a good reason for
PHP_INT_MAX
instead ofnull
. But if not, please let us remove that constant. I always feel bad if I have to use this constant with event_store.The text was updated successfully, but these errors were encountered: