Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandRouter class missed onRouteCommand method. #51

Closed
prolic opened this issue May 26, 2015 · 2 comments
Closed

CommandRouter class missed onRouteCommand method. #51

prolic opened this issue May 26, 2015 · 2 comments

Comments

@prolic
Copy link
Member

prolic commented May 26, 2015

See failing tests:

method Prooph\ServiceBus\Router\CommandRouter::onRouteCommand not found.

see: https://travis-ci.org/prooph/proophessor/jobs/64147997

Additional: Shouldn't the query-router have a onRouteQuery method?
@codeliner
Copy link
Member

proophessor test is fixed. See prooph/proophessor#25

I've changed the implementation due to the new QueryRouter. Command- and QueryRouter share the same base class SingleTargetRouter which now has a method onRouteMessage.

@prolic
Copy link
Member Author

prolic commented May 26, 2015

Great. Thanks.

@prolic prolic closed this as completed May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prolic @codeliner