Shebang parsing doesn't work for binary files

[jyn514]

String only works on valid UTF-8 :(

[panicbit]

I'd like to look into this.

[panicbit]

If this project isn't completely abandoned...

[jyn514]

@panicbit right - I have an open PR at #9 but it hasn't been reviewed in a year.

[oxr463]

@panicbit @jyn514 I would gladly assign either of you maintainer access for this rust implementation. I am currently the only "active" maintainer and to be honest, I barely have bandwidth for the main implementation.

[oxr463]

@KB5201314 has this been resolved with #14?

[imlk0]

@KB5201314 has this been resolved with #14?

No, there still seems to be a problem with this part, because the args are not handled properly.

proot-rs/src/kernel/execve/shebang.rs

Lines 168 to 170 in c34c982

	let mut argv = PathBuf::from(path.as_bstr().to_path().unwrap());
	argv.push(arg.as_bstr().to_path().unwrap()); // FIXME: why append arg here?
	Ok(Some(argv))

The current code will process #!/bin/sh -x into /bin/sh/-x

Maybe we have to replace the return value of this function from Result<Option<PathBuf>> with something else. Maybe Result<Option<(PathBuf, Bstring)>>?

[imlk0]

Fixed in #47