Bug fixes in BasePeer::doUpdate #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the issue #218, this fix is ok but you have to write a unit test (or more ;)) in order to prove the bug and that the fix is working. Cheers |
|
I have added a test that fails without the bug fix and passes with it. |
|
Please, squash your commits (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) |
Fixed bug when updating with no fields changed. Added test for propelorm#218 to BasePeerTest.php. Changed "unkown" to "unknown" throughout.
behavior was not applied
use getName instead of versionable to check if behavior is applied.
Error and BD break was introduced in 5ce2674 this commit fixes it
|
0671d6b is the squashed commit. |
|
@abrobston hmm, can you change the commit range ? |
|
Sure. The new commit range generated a new pull request, #236, so I'm closing the current one. |
willdurand
added a commit
that referenced
this pull request
Sep 9, 2013
Extend GlorpenPropelBundle description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I corrected a typo in a variable name for one changeset. That was not the bug. The other changeset should fix Issue #218.