-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes in BasePeer::doUpdate #219
Conversation
According to the issue #218, this fix is ok but you have to write a unit test (or more ;)) in order to prove the bug and that the fix is working. Cheers |
I have added a test that fails without the bug fix and passes with it. |
Please, squash your commits (http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) |
Fixed bug when updating with no fields changed. Added test for propelorm#218 to BasePeerTest.php. Changed "unkown" to "unknown" throughout.
behavior was not applied
use getName instead of versionable to check if behavior is applied.
Error and BD break was introduced in 5ce2674 this commit fixes it
0671d6b is the squashed commit. |
@abrobston hmm, can you change the commit range ? |
Sure. The new commit range generated a new pull request, #236, so I'm closing the current one. |
Extend GlorpenPropelBundle description
I corrected a typo in a variable name for one changeset. That was not the bug. The other changeset should fix Issue #218.