Added a common return type for Collection::getIterator() method #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tIterator() method
Codecov Report
@@ Coverage Diff @@
## master #1889 +/- ##
=========================================
Coverage 87.61% 87.61%
Complexity 7814 7814
=========================================
Files 227 227
Lines 21161 21161
=========================================
Hits 18541 18541
Misses 2620 2620
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dereuromark
approved these changes
Jun 27, 2022
…tIterator() method
…tIterator() method
dereuromark
reviewed
Jun 27, 2022
dereuromark
approved these changes
Jun 27, 2022
mringler
pushed a commit
to mringler/Propel2
that referenced
this pull request
Jun 28, 2022
…elorm#1889) * Adjusted docblock for collections in order to have common type for getIterator() method * Added a common interface for iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnDemandCollection::getIteratordocblock has not compatible type with the base class. Added a common type for both classes