Add a way to load fixtures from a specific bundle

[Palleas]

Today I wanted to load a set of fixtures from a specific bundle. With this PR you'll be able to do :

$ app/console propel:fixtures:load @MySuperBundle

What do you think?

[havvg]

I like the idea, but don't like the implementation, could you re-factor it into using the FileLocator?

[willdurand]

👍

[hhamon]

I don't like the @ before the name of the template. Can we just tell the bundle name instead?

[willdurand]

@hhamon isn't a kind of convention used in other bundles?

[havvg]

Is the actual path fixed, or do we want to specify a complete path to the fixtures directory.
Something like $ app/console propel:fixtures:load @AcmeBlogBundle/Resources/fixtures/demo? This would also allow to alter the fixtures of a bundle using bundle inheritance. The default fixtures directory will be unchanged, meaning app/propel/fixtures.

[hhamon]

I have never seen the @ notation from a CLI command in Symfony...

[havvg]

BehatBundle for example does it, to run features from a specific bundle.

[Palleas]

Yep, the cool thing with Behat commands is running very specifics scenarios with @Bundle/featurefile:line (for example) but I'm not sure we need that.
I'm ok to use the file locator (even if I'm not sure why, because I'm only retrieving a path so it works just like if we'd used the -d option), but @havvg can you tell me more about what you don't like in this implementation?
I wanted to keep it very simple and directly look for Resources/fixtures folder, "convention over configuration" or something like that ;-)

[willdurand]

Yeah, I like the @ notation, just update your PR using the FileLocator as @havvg said, and it will be ok.

[Palleas]

I'm sorry but I'm not sure I see what you mean when you want me to use the FileLocator, as all I'm doing is retrieving a path. You want to get rid of the absoluteFixturesPath property ?

[havvg]

There is a 'file_locator' service, which should be used to retrieve files/directories with a notation like you suggested, but the complete path. For example $this->container->get('file_locator')->locate('@AcmeBlogBundle/Resources/fixtures/demo/posts.yml'); which will yield the filename with bundle inheritance and other changes/customizations in mind. See https://github.com/propelorm/PropelBundle/blob/master/Command/AbstractPropelCommand.php#L234 for an example.

[hhamon]

For your information, the doctrine:generate:entities command does not take the @ notation for specifying a bundle name.

[Palleas]

I can remove it, I only had Behat in mind when I wrote this so...
I'll update this PR this afternoon, it's almost done :)

[Palleas]

Updated :)

[willdurand]

You should remove this blank line

[Palleas]

I thought it was in the Symfony2's CS?

[willdurand]

yes it is, but just if you have code before I think..

[willdurand]

See the first code example: http://symfony.com/doc/current/contributing/code/standards.html the first return in the transform method doesn't have a blank line before.

[Palleas]

Indeed, fixed!

[willdurand]

Thanks!

[Palleas]

Hiii, my first contribution to Propel \o/