Improve configuration tab's style #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed empty css files added override css file which can be used to override different style behaviours decreased size of jquery ui tabs fixes #310
These tabs used to be styled according to the default style-sheet provided by jQuery UI. They are now stylized like the rest of the site so they fit better with the design.
Since we are using a multi-column layout, the floating elements inside the tab container make the latter to lose its height so the element are displayed after the left-floating element (here the navigation menu). Solution found at http://stackoverflow.com/a/7476799/2663959.
|
Cool :) +1 |
| @@ -28,9 +27,10 @@ | |||
|
|
|||
| {% if page.configuration == true %} | |||
| <!-- Configuration stuff --> | |||
| <link rel="stylesheet" href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.10.4/themes/smoothness/jquery-ui.css"> | |||
| <link rel="stylesheet" href="//ajax.googleapis.com/ajax/libs/jqueryui/1.11.2/themes/smoothness/jquery-ui.css" /> | |||
| <link rel="stylesheet" type="text/css" href="/css/override.css" > | |||
There was a problem hiding this comment.
Missing trailing / to close the tag
There was a problem hiding this comment.
Since we are using HTML 5, this is not needed. The other ones don't have the closing slash so for the sake of consistency, let's keep it as is ; the one above has been updated. :-)
robin850
added a commit
that referenced
this pull request
Nov 23, 2014
Improve configuration tab's style
|
Ok, thanks for the review guys ! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request is a follow-up to #312. It fixes the style of configuration tabs so that they better fit the site's design. There are several commits to ease the review process and make blaming easier:
.conftabsand the left navigation ; there's a bug with left-floating elements so the content of the tab go under the navigation because the container lose it's height.Before:
After:
Fixes #310 and #329.
Have a nice day!