Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYNTAX_PROTO3 check in file generator breaks on protobuf-2.x #284

Closed
JackPaul opened this issue Aug 6, 2017 · 1 comment
Closed

SYNTAX_PROTO3 check in file generator breaks on protobuf-2.x #284

JackPaul opened this issue Aug 6, 2017 · 1 comment
Milestone
1.3.1

Comments

@JackPaul
Copy link

JackPaul commented Aug 6, 2017

protoc-c/c_file.cc: In member function ‘void google::protobuf::compiler::c::FileGenerator::GenerateHeader(google::protobuf::io::Printer*)’:
protoc-c/c_file.cc:123:14: error: ‘const class google::protobuf::FileDescriptor’ has no member named ‘syntax’
if (file_->syntax() == FileDescriptor::SYNTAX_PROTO3) {
^
protoc-c/c_file.cc:123:26: error: ‘SYNTAX_PROTO3’ is not a member of ‘google::protobuf::FileDescriptor’
if (file_->syntax() == FileDescriptor::SYNTAX_PROTO3) {
^
make: *** [protoc-c/protoc_c_protoc_gen_c-c_file.o] Error 1
make: *** Waiting for unfinished jobs....
@JackPaul JackPaul changed the title waht is the problem? what is the problem? Aug 6, 2017
@EvanKrall
Copy link

EvanKrall commented Aug 6, 2017 •
edited

Seems like the change in 712154b made protobuf-c require protobuf version 3+

SYNTAX_PROTO3 was introduced in protocolbuffers/protobuf@6ef984a#diff-00ab3a1ed34bccc2d8f9f5d21c105192R134, which is first included in v3.0.0-alpha1

@edmonds edmonds changed the title what is the problem? SYNTAX_PROTO3 check in file generator breaks on protobuf-2.x Aug 7, 2017
@edmonds edmonds added this to the 1.3.1 milestone Aug 7, 2017
@edmonds edmonds mentioned this issue Aug 7, 2017
Merged
reedjc added a commit to farsightsec/nmsg that referenced this issue Oct 23, 2017
@reedjc
on linux use next branch for the protobuf-c dependency for the Travis CI
92f9a17 
Travis CI was failing due to incompatibility of protobuf-c.

See protobuf-c/protobuf-c#284 and
protobuf-c/protobuf-c#285 for details.
reedjc added a commit to farsightsec/nmsg that referenced this issue Oct 24, 2017
@reedjc
on linux use next branch for the protobuf-c dependency for the Travis CI
8fc6f57 
Travis CI was failing due to incompatibility of protobuf-c.

See protobuf-c/protobuf-c#284 and
protobuf-c/protobuf-c#285 for details.
@edmonds edmonds closed this as completed Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.1
Development

No branches or pull requests
3 participants
@edmonds @EvanKrall @JackPaul