Restore protobuf-2.x compatibility #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in commit 712154b ("Bump minimum required header version for proto3 syntax") uses functionality only exposed by protobuf-3.x, breaking the build when compiling against protobuf-2.x. Since we still want to support building against protobuf-2.x, this commit makes the proto3 syntax check in the file generator dependent on building against protobuf-3.x.
|
@pbor Can you review this commit? |
|
Should fix #284. |
|
I am not on a pc where I can test right now, but it looks good to me if it
now compiles with both.
Il 07 Ago 2017 6:39 PM, "Robert Edmonds" <notifications@github.com> ha
scritto:
… @pbor <https://github.com/pbor> Can you review this commit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#285 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIEOrpW50O3EBpvI8JG0X5BqvqmyZZ4ks5sVz2ngaJpZM4OvrBx>
.
|
pbor
approved these changes
Aug 8, 2017
|
Compiling now works vs protobuf 2.6.1 as part of farsightsec/nmsg toolkit. |
reedjc
added a commit
to farsightsec/nmsg
that referenced
this pull request
Oct 23, 2017
Travis CI was failing due to incompatibility of protobuf-c. See protobuf-c/protobuf-c#284 and protobuf-c/protobuf-c#285 for details.
reedjc
added a commit
to farsightsec/nmsg
that referenced
this pull request
Oct 24, 2017
Travis CI was failing due to incompatibility of protobuf-c. See protobuf-c/protobuf-c#284 and protobuf-c/protobuf-c#285 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in commit 712154b ("Bump minimum required header version for proto3 syntax") uses functionality only exposed by protobuf-3.x, breaking the build when compiling against protobuf-2.x.
Since we still want to support building against protobuf-2.x, this commit makes the proto3 syntax check in the file generator dependent on building against protobuf-3.x.