Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect RPCImplCallback type declaration #767

Closed
rossenassenov opened this issue Apr 19, 2017 · 1 comment
Closed

Incorrect RPCImplCallback type declaration #767

rossenassenov opened this issue Apr 19, 2017 · 1 comment

Comments

@rossenassenov
Copy link

protobuf.js version: 6.7.1

The current type declaration for RPCImplCallback leads to compile errors in TypeScript in strictNullChecks mode:

type RPCImplCallback = (error: Error, response?: Uint8Array) => void;

the "error" param should be optional:

type RPCImplCallback = (error?: Error, response?: Uint8Array) => void;

I opened a PR: #766

@dcodeIO
Copy link
Member

dcodeIO commented Apr 20, 2017

Should be fixed in 23f4b99

@dcodeIO dcodeIO closed this as completed Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants