Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Bzlmod module to support Bazel6 #13618

Open
opicaud opened this issue Aug 21, 2023 · 13 comments
Open

Provide a Bzlmod module to support Bazel6 #13618

opicaud opened this issue Aug 21, 2023 · 13 comments
Assignees

Comments

@opicaud
Copy link

opicaud commented Aug 21, 2023

What language does this apply to?
If it's a proto syntax change, is it for proto2 or proto3? No
If it's about generated code change, what programming language? No

Describe the problem you are trying to solve.
Being able to use protobuf as module in a Bazel project

Describe the solution you'd like
Providing a MODULE.bazel file

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.
There is a draft here #12489 but not updated for April 2023, maybe @deannagarcia ?

If the request sounds valuable, i can contribute to provide the module file
Olivier

@opicaud opicaud added the untriaged auto added to all issues by default when created. label Aug 21, 2023
@zhangskz zhangskz added enhancement bazel and removed untriaged auto added to all issues by default when created. labels Aug 23, 2023
@zhangskz
Copy link
Member

Thanks for the request! We are interested in moving to Bzlmod in the near future and are in communication with Bazel folks on our side. We are currently blocking on the completion of some work to restructure our repositories which will also affect our existing WORKSPACE dependencies.

We expect to start on the Bzlmod effort shortly after and can update back here once this is staffed.

We do already officially support Bazel 6, but the rest of #12489 moving to platforms is currently on hold .

@meteorcloudy
Copy link
Contributor

FYI @comius

Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 29, 2023
@aaliddell
Copy link
Contributor

Still desired

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Nov 30, 2023
@bgdnvk
Copy link

bgdnvk commented Dec 6, 2023

running into this issue with gazelle and protobuffs deps

@railwaycat
Copy link

There are already patches under Bazel Central Registry to bring bzlmod support to protobuf. But only for several history versions. Is it possible to reuse those patches for the latest code?

Copy link

github-actions bot commented Apr 4, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Apr 4, 2024
@udf2457
Copy link

udf2457 commented Apr 4, 2024

ping

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Apr 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please add a comment.

This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jul 5, 2024
@udf2457
Copy link

udf2457 commented Jul 5, 2024

$hello_world

@meteorcloudy
Copy link
Contributor

protobuf is already published to https://registry.bazel.build/modules/protobuf and managed by the protobuf team.

@github-actions github-actions bot removed the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jul 6, 2024
@touchinglie
Copy link

I'm installing the ProtoBuf lib on my Radxa Rock 3A Debian Bullseye to compile the source code for NCNN.
When I executed the command,

bazel build :protoc :protobuf

it raise an error:

INFO: Reading rc options for 'build' from /home/radxa/protobuf-28.1/.bazelrc: Inherited 'common' options: --noenable_bzlmod --repo_env=BAZEL_NO_APPLE_CPP_TOOLCHAIN=1 ERROR: --noenable_bzlmod :: Unrecognized option: --noenable_bzlmod

I checked .bazelrc, and found this link.
Any Idea or help pls.

@meteorcloudy
Copy link
Contributor

@touchinglie Please upgrade your Bazel version to at least Bazel 6, ideally Bazel 7

@acozzette acozzette removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants