Fix validation errors response expectation #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evang522
changed the title
|
Thank you for the PR. We can not upgrade to EasyAdmin version from current one because Enums are not properly supported. So I have to keep this opened until an upgrade is possible. See |
|
Even if enum support is now broken, I will still merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy admin, in their most recent update: 4.6.5 -> 4.6.6 introduced a bug fix in which responses with form validation errors have a 422 code rather than a 200 code.
EasyCorp/EasyAdminBundle@ef7fed4
This means that the expected response codes here:
src/Test/Controller/EditActionTestCase.php:130and here
src/Test/Controller/NewActionTestCase.php:97need to be updated.