Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deletion of previously applied annotations. #120

Closed
merijnbeeksma opened this issue Oct 12, 2017 · 4 comments
Closed

Enable deletion of previously applied annotations. #120

merijnbeeksma opened this issue Oct 12, 2017 · 4 comments
Assignees
@proycon
Labels
bug PRIORITY ready
Milestone
v0.7.9

Comments

@merijnbeeksma
Copy link

Not deletion of a token, but of the actual annotation. Would be optimal if this could be done by clicking on the token instead of going through the edit history (in case you want to change someone else's annotations or correct an old annotation, for example).
@proycon proycon self-assigned this Oct 13, 2017
@proycon
Copy link
Owner

proycon commented Oct 17, 2017

Assigning an empty correction class should delete the correction, I'll investigate.

@proycon
Copy link
Owner

proycon commented Oct 17, 2017

Related bug #122 popped up; fixed now..

@proycon
Copy link
Owner

proycon commented Oct 17, 2017

It seems this was never properly reimplemented in the major refactoring for FLAT v0.7; working on it now....

@proycon proycon added bug and removed verify labels Oct 17, 2017
proycon added a commit that referenced this issue Oct 17, 2017
@proycon
Reimplenting editing correction class (#120), adding support for dele…
bf008d1 
…tions too (not done yet)
@proycon
Copy link
Owner

proycon commented Oct 17, 2017

I'm adding a new [DELETE....] RESTORE ORIGINAL keyword to FQL to facilitate this.

proycon added a commit to proycon/pynlpl that referenced this issue Oct 17, 2017
@proycon
[fql] Implemented DELETE...RESTORE ORIGINAL keyword (proycon/flat#120)
22e3dbc
@proycon proycon added this to the v0.7.9 milestone Oct 17, 2017
proycon added a commit to proycon/foliadocserve that referenced this issue Oct 17, 2017
@proycon
Documented new RESTORE ORIGINAL keyword (proycon/flat#120)
2b5759a
proycon added a commit that referenced this issue Oct 17, 2017
@proycon
Working on support for deletions with restoration of original (new FQ…
6670b91 
…L 'RESTORE ORIGINAL') #120
proycon added a commit to proycon/pynlpl that referenced this issue Oct 17, 2017
@proycon
[fql] Added extra tests for restoring original after deletion of stru…
cc597ee 
…ctural correction (proycon/flat#120)
@proycon proycon added the ready label Oct 17, 2017
@proycon proycon closed this as completed Oct 18, 2017
proycon added a commit to proycon/foliapy that referenced this issue Sep 6, 2018
@proycon
[fql] Implemented DELETE...RESTORE ORIGINAL keyword (proycon/flat#120)
5fdf8d4
proycon added a commit to proycon/foliapy that referenced this issue Sep 6, 2018
@proycon
[fql] Added extra tests for restoring original after deletion of stru…
0e219dc 
…ctural correction (proycon/flat#120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@proycon proycon

Labels
bug PRIORITY ready
Projects
None yet
Milestone
v0.7.9
Development

No branches or pull requests
2 participants
@proycon @merijnbeeksma