Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.7 development] Fix advanced correction handling after major refactoring #91

Closed
proycon opened this issue Nov 26, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@proycon
Copy link
Owner

proycon commented Nov 26, 2016

Major refactoring (issue #41) broke some of the advanced correction handling. The most common functionality works already though. This is testable using the correctionexample.folia.xml document. The following sums up the current state:

  • Corrections
    • non-structural: ok
    • structural (word)
      • merge: ok
      • split: ok
      • insertion: ok
      • deletion: fixed
      • nesting in current: ok
    • structural (sentence): partial: renders new sentence, but no access to original
  • Suggestions for correction
    • non-structural: ok
    • structural
      • merge: ok
      • split: ok
      • insertion: fixed
      • deletion: ok
      • suggestion over a nested correction (correction/current/correction): fails [regression, works in v0.6]

These functions are needed if FLAT is to serve as a replacement for the Valkuil interface eventually.

@proycon
Copy link
Owner Author

proycon commented Nov 26, 2016

Not all of these are regressions, some functionality wasn't ready in v0.6 either.

proycon added a commit that referenced this issue Nov 26, 2016
@proycon
Copy link
Owner Author

proycon commented Nov 26, 2016

Most regression problems after refactoring are fixed now

@proycon proycon added the ready label Dec 5, 2016
@proycon proycon closed this as completed Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant