New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrusaSlicer gets stuck in an endless "Warning" loop if you set the "Avoid crossing perimeters - Max detour length" value to be significant (e.g. 10) without using a "%" sign #6992
Comments
Could not reproduce in 2.4.0 beta 1. Fixed? |
I figured out what caused it; after entering a significant value in the field (such as 10), switch to a different window/application in Windows. The warning dialog pops up in the PrusaSlicer app while it is in the background, at which point refocusing on the PrusaSlicer application leaves it in the undismissable Warning loop. |
Ah ok. And it does not happen if the settings are in a modal window.
Result:
|
This issue should be fixed. |
Please add the commit that addresses this issue, or else state that it could not be reproduced and what version you attempted to reproduce it. |
Reproduced in Beta 2; opening a new issue since I cannot reopen this one. |
Thanks, reproduced. Reopening. |
@cloud30000 |
Downloading and installing Visual Studio now |
@bubnikv Is there a compiled Windows 64-bit version of this commit available to test with? |
https://prusaslicer:slicer@slicerbuilds.prusa3d.com/files/PrusaSlicer-2.4.0-beta2+96-win64-g303de63a9-202112040813.zip |
Could not reproduce any more with 2.4.0 beta 3. |
Cool, thanks. |
Work around 3D scene focus after de-activation of the main window without having to resort to CallAfter(), which breaks on Linux with some window managers that follow mouser cursor. Fixes #5620 #6870 #6992 3622f06 was not a correct solution, it broke focus for non-modal windows. Fixes #7419 The actual issue seems to be caused by wxProgressDialog not playing well with modal dialogs closed just before wxProgressDialog opens. If wxProgressDialog parent was not a main frame, keyboard focus was not restored correctly after the wxProgressDialog closed.
Version
Version 2.4.0-alpha1+win64
Operating system type + version
Windows 64 bit
3D printer brand / version + firmware version (if known)
Prusa MK3S+
Behavior
PrusaSlicer gets stuck in a "Warning" loop if you set the "Avoid crossing perimeters - Max detour length" value to be significant (e.g. 10) without using a "%" sign.
Selecting the "Yes", "No", or "x" buttons all just cause the Warning dialog to instantly regenerate.
There does not seem to be a workaround to exit the loop, as even positioning the buttons directly over the length text entry field does not return to the field for editing, just regenerating the Warning dialog again instead. PrusaSlicer must be closed from Task Manager to get rid of Warning dialog.
It appears as though the loop is detecting if the entry field is not currently the focus, which it cannot be anymore once the warning occurs, instead of detecting if exiting the field for the first time.
The text was updated successfully, but these errors were encountered: