Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless loop telling me 'Supports work better if the following feature is enabled: bridging perimeters' when setting 'generate support material' on a single object #7301

Closed
plampix opened this issue Nov 13, 2021 · 9 comments

Comments

@plampix
Copy link

plampix commented Nov 13, 2021

Version

2.4.0-beta1

Operating system type + version

Debian GNU/Linux 11

3D printer brand / version + firmware version (if known)

Not applicable

Behavior

Make sure support is off, detect bridging perimeters is off as well.
Add a Cylinder
Using the context menu, add 'Support material' to this object, and check 'Generate support material'.
A popup will appear
Screenshot_20211113_134230
Unfortunately there's no option to enable this option in this popup, like there is when you enable support from the print settings:
Screenshot_20211113_134329

The latter dialog also allows you to say 'No', and the slicer will continue. On the first dialog, if you click ok, the dialog closes, and immediately reopens. This will require a forced closing of the program, and you'll lose everything you've done until then.

@n8bot
Copy link
Contributor

n8bot commented Nov 14, 2021

I experienced the same thing, but I cannot remember the circumstances.

Are these intrusive messages really necessary? There must be a better way to communicate to the types of users that are being targeted with these messages.

@dartrax
Copy link

dartrax commented Nov 14, 2021

I can't reproduce on Win 10 x64, may be OS specific.
May be related to #6992.

@n8bot
Copy link
Contributor

n8bot commented Nov 14, 2021

I can't reproduce on Win 10 x64, may be OS specific. May be related to #6992.

I experienced this issue on Win 10 64.

@dartrax
Copy link

dartrax commented Nov 14, 2021

Could depend on other settings (GUI preference etc.) like in #6992. I tried with different settings but I might have missed some.

@plampix
Copy link
Author

plampix commented Nov 14, 2021

Yes, sorry, in one of my print profiles I've got 'Detect bridging perimeters' disabled. Only then do you get the dialog when you enable support.

@dartrax
Copy link

dartrax commented Nov 15, 2021

I know, I also get the dialog as you described, but it doesn‘t come again after clicking OK. What‘s your GUI setting? Do you have background processing enabled?

YuSanka added a commit that referenced this issue Nov 15, 2021
…following feature is enabled: bridging perimeters' when setting 'generate support material' on a single object

This bug was from 0c29eb9
@YuSanka
Copy link
Collaborator

YuSanka commented Nov 15, 2021

Thanks for your report. This bug is fixed and will be a part of upcoming release.

@YuSanka YuSanka closed this as completed Nov 15, 2021
@plampix
Copy link
Author

plampix commented Nov 15, 2021

I can confirm this fixes the problem. It would be 'nice to have' the option to add an object specific 'Detect bridging perimeters' setting to the object in question.

@n8bot
Copy link
Contributor

n8bot commented Dec 6, 2021

I have encountered this endless loop once again.

The "Support works better, if..." dialog enters an endless loop...

If you are in a scenario where the dialog has asked you once already if you want to detect bridges, and you select no... then you add a modifier to a model. Then, you attempt to add the setting Fuzzy Skin, it will bring up the endless loop dialog -- only OK button, which dismisses it then it pops back up.

image

It enters the endless loop even if you disable the else statement:

}
else {
m_support_material_overhangs_queried = false;
}

Which needs to be disabled, because otherwise the popup comes every single time supports are enabled while detect bridging perimeters is not.

Whether or not we agree that supports work better with detect bridging enabled (ahem...), this intrusive popup is causing endless issues. Literally. Is this specific popup very useful? The other messages coded next to it seem more useful and less intrusive/broken. I propose dropping just the support/bridging perimeters dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants