-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: Seam at preferred location #728
Conversation
Added a new modifier "lambda-seam" to define a preferred location for the seam in "rear"-mode. The preferred location can be changed in respect to z-height by placing multiple modifiers in different heights.
Added a new modifier "lambda-seam" to define a preferred location for the seam in "rear"-mode. The preferred location can be changed in respect to z-height by placing multiple modifiers in different heights.
Added a new modifier "lambda-seam" to define a preferred location for the seam in "rear"-mode. The preferred location can be changed in respect to z-height by placing multiple modifiers in different heights.
Logged in just to say thanks for giving this a go!! Big ups to you for contributing and giving the coding a shot, hopefully it works well and can be implemented (and perhaps a bit polished by the pros by adding a separate option for "Custom" as a seam position). But great idea for a feature, IMO something Slic3r has been missing for quite some time. |
Thank you, @austinvojta, for that kind words! |
I would LOVE to see this be implemented! This is a fantastic feature that looks like its almost there! Really great job dartrax! |
Interesting use of lambda modifiers by the way. |
Thank you, @lordofhyphens! Thank you too, @daragill =) I have to admid that I have one or two bugs in this commit (at least ;-) ):
I hope to find time to improve this commit soon. Of course, anybody else is welcomed to join. |
I may steal it for main Slic3r :)
I am glad people are thinking of more interesting uses for lambda meshes.
…On Tue, Apr 3, 2018, 6:34 AM dartrax ***@***.***> wrote:
Thank you, @lordofhyphens <https://github.com/lordofhyphens>! =)
This way, we have visual feedback of the preferred position of the seam in
respect to the actual CAD model. This is far better than Simplify3D with
their unintuitive X-Y-Coordinate-Setting.
I have to admid that I have one or two bugs in this commit:
1. If the model is rotated around the Z axis, the resulting seam
position is misplaced (as if the model was not rotated)
2. Sometimes the seam gets placed at a concave edge that is too far
away from the preferred position in my opinion. I should finetune that.
Additionally, I would like to implement an option to neglect the
overhang of a vertice.
I hope to find time to improve this commit soon. Of course, anybody else
is welcomed to join.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#728 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAB8CqSfU5gqc_JuDSEUdhVmcAD5OxLSks5tk14_gaJpZM4SJ2c9>
.
|
…preferred-Location-Feature
- Added Weight-Parameter to the Seam Lambda Modifier to be able to define how steep an overhang may be to be ignored or avoided in seam positioning - Fixed a bug where custom seam was not positioned correctly on rotated or scaled objects
Hello, First, the changes:
What's next? How to test? Some examples |
Hello!, Can you see the Seams?? ;P Other programs use different methods for this but none has ever convinced me (CraftWare only, but it seems quite unfinished in many things). In all versions of Slic3r the seams end up being either a mess or a problem. Slic3r has not had much success in general to generate custom seams and the options that there are, in my opinion, are very loose. For me the control of the seam points is essential, with a good alignment of seams and strategy (as Zortrax Z-Suite does) you can control the flow of filament to that point and that is always the same in the retraction to obtain results like those ("Rear" does not work well there and the back part of the pulley was a chaotic seam as with "Aligned"). Why was this project stopped? I find an incredible breakthrough and the brilliant idea of using lambda modifiers. If I could I would like to contribute some ideas to this project to get pieces with an incredible finish. I tried to update Slic3r myself to the latest version of Slic3rPE recompiled it with this "mod" but it escapes my little programming knowledge. |
Hi ememolero! I'd have assumed that "aligned" should have worked, too, because "aligned" tries to place the seam in a concave edge and should have found that in the ground of the gear teeth. One reason I can think of is that the concave edges might be too much rounded to be found by the "aligned" algorythmus. This is not a real project, it is more like a quick fix for me to get this functionality for my own needs, and I like to share it because - of course - I would like to see this as an offical feature in Slicer, which would mean that I don't need to recompile if I want to use the newest slicer updates ;-) That didn't happen yet and we can only speculate about the reasons. Fact is that this is not yet fully thought from the user interface point of view and other opinions how to design the user interactions exist: #946 So to continue using this "mod" with the newest slicer update, the conflicts must be resolved. This shouldn't be too hard because the ObjectPartsPanel.pm only affects the UI, not the underlying algorythm. However, I can't promise anything with this because I'm new to git and every commit and co still takes some time for me to understand and work through the errors, and I'm a little bit short with time right now... |
Please work on this! This is absolutely amazing for production-ready parts |
+1000 for this |
This could be really good! |
hahaaAAaa this is fantastic. i have been wanting this feature for ages. well done. youve made me not so chicken about contributing to open source stuff / this project. especially cos i am both new to C++ and new to contributing to open source too. nice work. |
@dartrax Are you still working on this? I'd like to test this with the current slicer. |
Hi, |
Any way how such feature can be pulled in to prusa slicer? I have not found a slicer having a proper control for the seam. I'm printing organinc shapes, so I would love to have a better control (no places to realy hide a seam). |
Check how kisslicer does this. You specify a vector and a an angle spread for seam positions. Makes it possible to still randomize it, but just on one sector of the part. Fairly intuitive interface as well |
Hi @wesc23, |
I can't seem to get the preview of the sliced objects to display "travel" "retractions" and "unretractions", "shells" is also greyed out. Is there something simple I need to do to fix this? |
@derekonilsen, do you refer to the 1.4 alpha from this #728 (comment) post? This is a very old release where the feature you mentioned was still in development and not ready to use. |
Yes, that is what I am referring to. Is there an updated version? |
No, but I've seen a very interesting comment by @lukasmatena here: #2527 (comment) You could also try a new fork by @supermerill: https://github.com/supermerill/SuperSlicer/wiki
And it will have something very similar soon: supermerill#152 (comment)
|
We have implemented a paint-on custom seam for 2.3 release. Currently in master, alpha should be out in less than two weeks. There is no extra 'custom seam' option like in this PR, custom seam areas just limit where the "normal" options should be used. It took a long time but we got there. Please, report any issues. This PR came in times when slicer was already being rewritten from Perl to C++ and the modifiers were extensively worked on, so integrating it was hardly possible. We also hoped to make a better UI than to use the modifier mesh hack, which we hopefully did. There's no point in keeping this open now. Sorry, @dartrax . |
No need to be sorry @lukasmatena, I appreciate that there will be a much better solution! I'm looking forward testing it in the next alpha. |
This was requested and proposed here: #342
A new modifier "lambda-seam" can be specified and the seam will be aligned nearest to this modifier, when in
"rear"new "Custom"-alignment mode.The rule is as follows:
If there is no modifier, "
rearAligned" will be used (no change to usual rear alignment behavior). If there is a lambda-seam-modifier, it will control the preferred seam location for this and every layer above up to the next lambda-seam-modifier.This is my first contribution to Slic3r, my first work in c++ and perl, and also my first contribution in any open source project ever - I'm still learning how this things work, but that feature was very important for my daily work.
PS: This are actually just 3 commits, I made some mistakes with uploading files in first step. My git environment is under maintenance... :-P