-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Sharded TxPool #161
Comments
Hey @terenc3t this is a duplicate of #153 |
Ah! My bad |
I don't think this is a duplicate of #153. #153 outlines the work to create a service to broadcast "fake" transactions through the same mechanism that the P2P library would be broadcasting them within the application. In other words, #153 is supposed to be a stub for P2P that provides a stream of transactions for the proposer to use for development and testing. It is then up to the proposer to decide where to put these transactions. It would likely be a transaction pool so that is why we have this issue. |
I have written this tx pool design doc but it might be an over kill for Ruby release Let's strip it down and come back with a simpler design |
Should we close this ? we do not really know right now what shards would look like and how a txpool would be used in a shard |
This is still a very valid issue and can be implemented anytime. Proposer needs a txpool to store tx, it doesn't have to do with shards, it's just a priority queue. This is up to the client team to design |
Let's close this in favor of a new one when ethereum/consensus-specs#90 gets finalized |
We'll need to design and implement a sharding specific transaction pool. One prominent use case of the transaction pool is for the proposer to insert fake transactions. P2P implementation may want to use the receiving of test transactions in the transaction pool. This issue will have impact to proposer implementation as opened in #111
Some questions to answer:
What are the use cases?
How will it work?
Why is it necessary rather than a global TxPool with geth’s current implementation?
The text was updated successfully, but these errors were encountered: