Proposer Is Creating Collation For Every Received Transaction

[prestonvanloon]

This should be batching transactions into a transaction pool.

https://github.com/prysmaticlabs/geth-sharding/blob/b883562e12344c7eeab25b5fb24133fc820b6f05/sharding/proposer/service.go#L80-L101

Please wait for #222 to be merged as there will be some changes to the p2p message types.

[prestonvanloon]

Maybe depends on #161. @terenc3t can you confirm?

[nisdas]

It looks like it happens because everytime a transaction is received in the channel a collation is proposed. One solution is to make the channel buffered and have a condition

if len(p.msgchan) == size {

collationtx := make( []types.Transaction,0,len(p.msgchan)) 

for (i  = 0; i < len(p.msgchan) ; i++ ){
tx := <- p.msgchan
collationntx = append(collationtx,tx...)
}

err := p.createCollation(p.ctx, collationtx)
}

where size would be the number of transactions in the collation

[rauljordan]

@nisdas can you open a PR for this and try out your suggestion?