-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update next slot cache correctly under late task #12462
Update next slot cache correctly under late task #12462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, Deepsource's complain can be actually be satisfied this time.
lastRoot, lastState = headRoot[:], headState | ||
} | ||
if err := transition.UpdateNextSlotCache(ctx, lastRoot, lastState); err != nil { | ||
log.WithError(err).Debug("could not update next slot state cache") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.WithError(err).Debug("could not update next slot state cache") | |
log.WithError(err).Debug("Could not update next slot state cache") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…next-slot-skip-slot-all-the-time
…next-slot-skip-slot-all-the-time
In the event there's a late block coming (ie, no block 4s mark), we should still update the next slot cache without proposing the next slot
Also fixed a deep source complaint on:
Remove the internal goroutine and call the function using 'go'