Refactor Late Block Tasks #12469
Closed
Refactor Late Block Tasks #12469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
May 26, 2023
| // Head root should be empty when retrieving proposer index for the next slot. | ||
| _, id, has := s.cfg.ProposerSlotIndexCache.GetProposerPayloadIDs(s.CurrentSlot()+1, [32]byte{} /* head root */) | ||
| // There exists proposer for next slot, but we haven't called fcu w/ payload attribute yet. | ||
| if (has && id == [8]byte{}) || features.Get().PrepareAllPayloads { |
There was a problem hiding this comment.
This doesn't work, this will call fcu even after a timely block if the prepare-all-payloads flag is used
terencechain
approved these changes
May 27, 2023
|
No longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
Refactors our late blocks method to only send FCUs for active proposers or if we use the
PrepareAllPayloadsfeature. This importantly only updates our next slot cache after the FCU is sent to allow the EL to have a bit longer to start preparing their payload.Which issues(s) does this PR fix?
Alternative to #12462
Other notes for review