Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turkish i problem #45

Merged
merged 1 commit into from
Jan 18, 2013
Merged

Turkish i problem #45

merged 1 commit into from
Jan 18, 2013

Conversation

yadazula
Copy link
Contributor

@yadazula yadazula commented Jul 8, 2012

Hi, calling powershell functions which start with i throwing error in Turkish culture. You can repro problem easily by setting current culture to Turkish before calling import-module in psake.ps1.

[System.Threading.Thread]::CurrentThread.CurrentCulture = "tr-Tr"

This commit fixes it by setting current culture to invariant.

JamesKovacs added a commit that referenced this pull request Jan 18, 2013
@JamesKovacs
Merge pull request #45 from yadazula/master
e27307d 
Turkish i problem
@JamesKovacs JamesKovacs merged commit e27307d into psake:master Jan 18, 2013
whut added a commit that referenced this pull request Jan 5, 2014
@whut
Dropped changing CUrrentCulture to prevent "turkish i" problem (issue #…
8ce44c0 
…45) as it is now correctly fixed in c35bb4c (issue #70)

Also psake.ps1 should not change it's environment in any way, it's rude:)
Also fix for crash introduced in previous commit (e49692a) when removing default value for $buildFile argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yadazula @JamesKovacs