Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESP to --preview for stable #2756

Closed
felix-hilden opened this issue Jan 10, 2022 · 9 comments · Fixed by #2789
Closed

Add ESP to --preview for stable #2756

felix-hilden opened this issue Jan 10, 2022 · 9 comments · Fixed by #2789
Labels
C: configuration CLI and configuration F: strings Related to our handling of strings T: enhancement New feature or request

Comments

@felix-hilden
Copy link
Collaborator

A preview flag is added in #2751, which could also contain experimental string processing. So shall we convert ESP there? Or are we still thinking about making it stable very soon?

@felix-hilden felix-hilden added T: enhancement New feature or request C: configuration CLI and configuration stable labels Jan 10, 2022
@JelleZijlstra
Copy link
Collaborator

I don't think there's enough time to turn it on by default in this month's release. We should include it in the --preview feature set though.

@ichard26 ichard26 added the F: strings Related to our handling of strings label Jan 10, 2022
@felix-hilden
Copy link
Collaborator Author

felix-hilden commented Jan 16, 2022

Do we want to keep the existing ESP flag simultaneously with its --preview addition?

Personally, I'd want to remove it and a first stable release seems like a good excuse, but Jelle raised a good point about keeping compatibility on Discord. This could also affect the feature flag machinery implementation in #2752.

@Shivansh-007
Copy link
Contributor

I would be fine with removing the ESP flag as we are doing a major stable release, so "breaking" a bit of compatibility is fine.

If we decide to keep it for compatibility reasons, we could deprecate the flag and add some sort of "warning" log when someone uses an ESP flag. The deprecation could either still preserve the flag's functionality or direct the user to the new --preview flag (without actually doing anything, just outputting a simple message).

@felix-hilden
Copy link
Collaborator Author

Hmm, redirecting users sounds even better! I'm thinking: catch the use of ESP and throw before doing anything with a message telling people to use --preview.

But a softer deprecation works as well!

@JelleZijlstra
Copy link
Collaborator

I disagree with the idea that "we're doing a stable release, so we can break things". We've spent too many years in "beta" to keep that distinction meaningful.

My preference is to keep the behavior of the existing flag the same, but deprecate it and fold it into --preview in a few releases.

@Shivansh-007
Copy link
Contributor

catch the use of ESP and throw before doing anything with a message telling people to use --preview.

Yeah, that's what I meant 👍🏻

My preference is to keep the behavior of the existing flag the same, but deprecate it and fold it into --preview in a few releases.

By few releases, do we mean major releases or 22.X?

@felix-hilden
Copy link
Collaborator Author

I imagine yes, in a few minor releases. "In a few years" sounds too much 😄 So we'll do the soft deprecation! I'll work on it later today.

@JelleZijlstra
Copy link
Collaborator

There is no such thing as a major or minor release on this project. We use calendar versioning.

@felix-hilden
Copy link
Collaborator Author

Yeah, I meant the second number place, I don't really know what they are called in calver. Anyways, as you said, "in a couple of releases".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: configuration CLI and configuration F: strings Related to our handling of strings T: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants