Restore all cursors, instead of only the current window #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JelleZijlstra, @zsol, could you take a look? Thanks! |
|
Sorry I don't know anything about vim plugins :( I'm definitely not the right person to review this |
|
@ambv, could you see if this change is good? |
If we have the same buffer open in multiple windows/tabs, we'll only restore the current window's cursor. Iterate through all tabs and windows, and save/restore all cursor positions of windows that contain our buffer. Addendum to #433.
|
Sorry, I merged another PR which fixes the cursor to be restored to line of code instead of line in file. This conflicts now. Could you rebase your fix? |
|
I took a look at #989, and I don't think this change is compatible with that PR. Making an additional pass at the file contents gets expensive if you're to scale for Feel free to decline this PR, or back the other out and place this one in instead. |
|
Thanks! ✨ 🍰 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have the same buffer open in multiple windows/tabs, we'll only restore the current window's cursor.
Iterate through all tabs and windows, and save/restore all cursor positions of windows that contain our buffer.
Addendum to #433.