Restore cursor to same line of code, not same line of buffer #989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the way that the new cursor location in the buffer is determined. It is a two-step process. First, all code ahead of the cursor is run through the Black formatter, and the new length of the code ahead of the cursor is determined. This sets the new location of the cursor. Second, the entire buffer is run through Black, as it was previously.
The end result is that the user can call the Black formatter and have the cursor remain on the same line of code as it was before and after the Black formatting process.
To make sure the code ahead of the cursor will pass through the Black formatter okay, we check if the last line ends with
:
and if so we tackpass
onto the end.This pull request is not very robust to corner cases (yet). For example, if the cursor is located in the middle of a long, multi-line list of arguments.