Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky CI runs #15

Closed
exhuma opened this issue Aug 14, 2023 · 3 comments
Closed

Flaky CI runs #15

exhuma opened this issue Aug 14, 2023 · 3 comments

Comments

@exhuma
Copy link

exhuma commented Aug 14, 2023

          Some of the test runs have been a bit flaky.  Not sure what the deal is.  Thanks for your PRs though!

Originally posted by @kevin1024 in #11 (comment)

I've looked into the CI definition and saw just now that the jobs have a timeout of 10 minutes:

timeout-minutes: 10

This confirms my suspicion from my earlier post. I've noticed on a friend's laptop that docker is painfully slow on macOS. And - with an educated guess - I assume that the GitHub CI jobs run on docker containers.

This might explain the failures I had above. What do you think about either removing the timeout or increasing it considerably? Maybe we could remove it to get a rough feeling of how long those jobs take?

@kevin1024
Copy link

What do you think about either removing the timeout or increasing it considerably? Maybe we could remove it to get a rough feeling of how long those jobs take?

This is a good theory. Let's give it a shot. If you open a PR removing the timeout, will CI run without the timeout in that PR?

@exhuma
Copy link
Author

exhuma commented Aug 14, 2023

If you open a PR removing the timeout, will CI run without the timeout in that PR?

There's an easy way to find out 😄 I'll get on that

@exhuma exhuma mentioned this issue Aug 14, 2023
3 tasks
@kevin1024
Copy link

Resolved?? by #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants