Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the NETRC environment variable #5643

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Respect the NETRC environment variable #5643

merged 1 commit into from
Nov 1, 2020

Conversation

tarmath
Copy link

@tarmath tarmath commented Oct 30, 2020

Resurecting #4339 with incorporated review/feedback

Fixes #4318

.gitignore Outdated Show resolved Hide resolved
sigmavirus24
sigmavirus24 previously approved these changes Oct 31, 2020
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I'm fine with adding support. Left a quick question about the current implementation.

requests/utils.py Outdated Show resolved Hide resolved
requests/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good to me. Thanks @tarmath!

@nateprewitt nateprewitt merged commit 2f70990 into psf:master Nov 1, 2020
@nateprewitt nateprewitt mentioned this pull request Nov 10, 2020
@rgevaert
Copy link

@tarmath thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netrc reading does not respect NETRC environment variable
5 participants