updated get_encoding_from_headers to return utf-8 if the content type is set to application/json
#5673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe is set to application/json, following RFC 4627. fixes psf#5667
sigmavirus24
approved these changes
Nov 29, 2020
|
Awesome, thanks for the fast responses here and for merging! |
Merged
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5667 by adding a small bit of code to
get_encoding_from_headersthat returnsutf-8if the content type is set toapplication/jsonandcharsetis not set. This follows RFC 4627 (ctrl+f forshall be) which reads: "JSON text SHALL be encoded in Unicode. The default encoding is UTF-8."