Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: UMD export #4

Closed
Finesse opened this issue Mar 15, 2018 · 1 comment
Closed

Feature request: UMD export #4

Finesse opened this issue Mar 15, 2018 · 1 comment

Comments

@Finesse
Copy link
Contributor

Finesse commented Mar 15, 2018

Hi! The library is great but in has a disadvantage: it doesn't support Common JS import (i.e. const workly = require('workly');).

I understand that NodeJS doesn't support web workers but CJS is used in other cases, e.g. in Electron (which supports both browser and NodeJS APIs) or bundling JS files using Rollup.

I thing exporting the library in the UMD format is a great solution.

@Finesse Finesse mentioned this issue Mar 15, 2018
@pshihn
Copy link
Owner

pshihn commented Mar 15, 2018

Thanks. I was planning this, never got around to it. Ideally, I'd want to create multiple build outputs. workly.js, workly.umd.js, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants