New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build helper, take 2 #3021
Merged
Merged
build helper, take 2 #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathonMisiewicz
previously approved these changes
Aug 9, 2023
loriab
force-pushed
the
interim_misc_July2023_rb1
branch
from
November 4, 2023 05:25
277bd75
to
4e8ade7
Compare
JonathonMisiewicz
dismissed
their stale review
November 13, 2023 14:28
Many revisions since original approval
jturney
reviewed
Nov 20, 2023
jturney
approved these changes
Nov 22, 2023
davpoolechem
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #3016 (supersedes)
closes #3084
User API & Changelog headlines
psi4-dev
conda package that brought psi4 build dependencies and a "psi4-path-adivsor.pyscript that produced cmake configure lines. Now, that script is in-repo at
conda/psi4-path-advisor.py` and running the help menu provides the following. This should be more configurable for folks who like to choose all conda or byo.Dev notes & details
codedeps.yaml
file that makes dependency and ecosystem information programmatically accessible. Presently useful for (1) people and (2) the in-repo psi4-path-advisor.py script, but more uses can follow.conda/psi4-path-advisor.py
script to serve as build helper. this is the main point of the PR. will elaborate more in future.CMAKE_<LANG>_COMPILER
instead of cluttering up the user choice varCMAKE_<LANG>_FLAGS
. This is especially relevant for intel compilers that need gcc passed. There's something that's not set up right yet for Intel Clang. Thus, we need to passCMAKE_<LANG>_COMPILER_ARG1
through to psi4 subproject and all other externals.ADDED 12 Nov
sed
ing the envs.psi4 --version
tripped the problem, hence thesed
.psi4 --psiapi
variation onpsi4 --psiapi-path
that can be used ineval $(psi4 --psiapi)
Checklist
Status