add integratorxx to buildsys #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} | ||
| -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR} | ||
| -DCMAKE_INSTALL_INCLUDEDIR=${CMAKE_INSTALL_INCLUDEDIR} | ||
| -DCMAKE_CXX_STANDARD=${psi4_CXX_STANDARD} |
There was a problem hiding this comment.
@loriab FWIW - I don't respect this flag in IntegratorXX - it's a C++17 library, you could conceivably compile with 20 / 2b, but definitely not with 14. Would you prefer that I have a check on my end if you're requesting < 17 and bail? Or should ENABLE_IntegratorXX be contingent on 17+?
There was a problem hiding this comment.
all of Psi4 is 17, so in practice it's not an issue?
(only reason parts of psi could be 14 is if someone needed to use a ~3yo icpc with Libint2.)
9 tasks
davpoolechem
approved these changes
Mar 22, 2024
JonathonMisiewicz
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for now must enable with-D ENABLE_IntegratorXX=ON. recc installing catch2 first to avoid downloading each time.CI will fail because I added a integratorxx header to a file for trial, but haven't enabled the addon in the buildsys everywhere.User API & Changelog headlines
-D ENABLE_IntegratorXX=ONChecklist
Status