Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More space between menu elements in 0.2-1? #21

Closed
michaldybczak opened this issue Nov 24, 2018 · 7 comments
Closed

More space between menu elements in 0.2-1? #21

michaldybczak opened this issue Nov 24, 2018 · 7 comments

Comments

@michaldybczak
Copy link

michaldybczak commented Nov 24, 2018

I don't have the comparison but I have a feeling as if after update menu main positions are a bit too wide? Just a little bit, one or few pixels?

Was that changed or am I paranoid? I may get used to it but now it feels a bit off.

Ah, wait. I did find it in old screenshots so I have the comparison:

NEW
screenshot-2018-11-24-14-15-15

OLD
screenshot-2018-11-24-14-15-27

I liked the old spacing much better and more consitent to what were used to in applications.

By the way, nice new effect when the menu is too long:
screenshot-2018-11-24-14-09-54

It looks better than overlapping, still some limitation on the size with the ... an effect like in original AWC menu would be good.

@kupiqu
Copy link

kupiqu commented Nov 24, 2018

That is hard to compare in the screenshots, but there is space between the different buttons. I don't recall happening this before (neither in plasma's global menu), and I recall having to readjust the title applet to adjust for equal separation wrt the appmenu.

I would prefer not having separation between buttons in appmenu because the buttons margins bring separation themselves, and usually panels have more stuff other than the appmenu, so for applications with large number of menus, these extra space may make things to overlap and look bad.

Ideally, this space between buttons could be removed, or if someone for whatever reason thinks they are a good thing to have, then give an option to adjust that, so users can set it to 0 if wanted.

EDIT: the new screenshot is good

@psifidotos
Copy link
Owner

The difference is so small that I wouldn't consider it important. Spacing between menu elements is still units.smallSpacing like before... If anyone can find in the code other reason for the spacing I could look at it

@kupiqu
Copy link

kupiqu commented Nov 24, 2018

what do you mean with If anyone can find in the code other reason for the spacing I could look at it ?

I don't understand the association between code and reason there, do you mean an alternative to units.smallSpacing?

@psifidotos
Copy link
Owner

I mean that plasma app menu is using units.smallSpacing also. If you think that this applet violates that somehow feel free to point me to where this happening

@kupiqu
Copy link

kupiqu commented Nov 24, 2018

I mean that plasma app menu is using units.smallSpacing also. If you think that this applet violates that somehow feel free to point me to where this happening

I see. That's correct (I checked) but somehow buttons in plasma's global menu are closer together.

@psifidotos
Copy link
Owner

Yeah you are right, look at PaintedToolButton there is a property implicit Width, what do you think a good spacing would be for this?

Might be a good idea the GridLayout spacing to make it zero that would help also with Fitts Law and make the button implicit Width to use only one units.smallSpacing and not two

@psifidotos psifidotos reopened this Nov 24, 2018
@kupiqu
Copy link

kupiqu commented Nov 24, 2018

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants