Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for raw attributes #65

Closed
1 of 2 tasks
pedromxavier opened this issue Feb 16, 2023 · 0 comments · Fixed by #66
Closed
1 of 2 tasks

Restore support for raw attributes #65

pedromxavier opened this issue Feb 16, 2023 · 0 comments · Fixed by #66
Assignees
Labels
bug Something isn't working need tests Feature still require tests to be added urgent Immediate attention needed

Comments

@pedromxavier
Copy link
Member

pedromxavier commented Feb 16, 2023

While adjusting the attribute dispatch flow for v0.1.5, support for raw attributes was not defined properly.

using JuMP, ToQUBO, DWaveNeal

# This works
model = Model(DWaveNeal.Optimizer)

set_optimizer_attribute(model, "num_reads", 8_000)

# This also works
model = Model(() -> ToQUBO.Optimizer(DWaveNeal.Optimizer))

set_optimizer_attribute(model, DWaveNeal.NumberOfReads(), 8_000)

# This does not
model = Model(() -> ToQUBO.Optimizer(DWaveNeal.Optimizer))

set_optimizer_attribute(model, "num_reads", 8_000) # error

Tasks

  • Add tests
  • Forward MOI.get and MOI.set to the underlying solver
@pedromxavier pedromxavier added bug Something isn't working need tests Feature still require tests to be added urgent Immediate attention needed labels Feb 16, 2023
@pedromxavier pedromxavier self-assigned this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need tests Feature still require tests to be added urgent Immediate attention needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant