-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ToQUBO Compiler Upgrade #77
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
===========================================
+ Coverage 70.56% 80.92% +10.35%
===========================================
Files 24 31 +7
Lines 1247 1143 -104
===========================================
+ Hits 880 925 +45
+ Misses 367 218 -149
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive PR with many improvements. Good work. Many of the tests, if I understand correctly, were just moved to other packages.
My comments are really minor. Well done Pedro!
This PR aims to make the reformulation modular, helping the development and testing of its current and subsequent features.
The necessary tasks to merge it are:
NTR_KZFD
quadratization dispatch not being called #69)Compiler
module (closes Placetoqubo_*
methods inside newCompiler
module #75)