Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToQUBO Compiler Upgrade #77

Merged
merged 38 commits into from
Nov 14, 2023
Merged

ToQUBO Compiler Upgrade #77

merged 38 commits into from
Nov 14, 2023

Conversation

pedromxavier
Copy link
Member

@pedromxavier pedromxavier commented Oct 30, 2023

This PR aims to make the reformulation modular, helping the development and testing of its current and subsequent features.

The necessary tasks to merge it are:

@pedromxavier pedromxavier added documentation Improvements or additions to documentation enhancement New feature or request need tests Feature still require tests to be added next steps Interesting follow-up feature labels Oct 30, 2023
@pedromxavier pedromxavier self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 144 lines in your changes are missing coverage. Please review.

Comparison is base (ac8be79) 70.56% compared to head (96b02fd) 80.92%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #77       +/-   ##
===========================================
+ Coverage   70.56%   80.92%   +10.35%     
===========================================
  Files          24       31        +7     
  Lines        1247     1143      -104     
===========================================
+ Hits          880      925       +45     
+ Misses        367      218      -149     
Files Coverage Δ
src/ToQUBO.jl 100.00% <ø> (ø)
src/compiler/compiler.jl 100.00% <100.00%> (+17.02%) ⬆️
src/compiler/objective.jl 100.00% <100.00%> (ø)
src/encoding/encoding.jl 100.00% <100.00%> (ø)
src/encoding/variables/interval/bounded.jl 100.00% <100.00%> (ø)
src/model/qubo.jl 76.27% <100.00%> (+1.69%) ⬆️
src/virtual/model.jl 100.00% <100.00%> (ø)
src/virtual/variable.jl 100.00% <100.00%> (ø)
src/virtual/virtual.jl 100.00% <100.00%> (ø)
src/compiler/build.jl 90.62% <96.42%> (+9.26%) ⬆️
... and 20 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bernalde bernalde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive PR with many improvements. Good work. Many of the tests, if I understand correctly, were just moved to other packages.
My comments are really minor. Well done Pedro!

src/compiler/build.jl Outdated Show resolved Hide resolved
src/compiler/build.jl Show resolved Hide resolved
src/compiler/build.jl Outdated Show resolved Hide resolved
src/virtual/model.jl Outdated Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/unit/encoding/encoding.jl Outdated Show resolved Hide resolved
@pedromxavier pedromxavier merged commit 072730a into master Nov 14, 2023
6 checks passed
@pedromxavier pedromxavier deleted the px/compiler branch November 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request need tests Feature still require tests to be added next steps Interesting follow-up feature
Projects
None yet
2 participants