-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable packit #58
Enable packit #58
Conversation
There was an error while creating a SRPM. Output:
Return code: 2 |
There was an error while creating a SRPM. Output:
Return code: 127 |
There was an error while creating a SRPM. Output:
Return code: 1 |
There was an error while creating a SRPM. Output:
Return code: 1 |
There was an error while creating a SRPM. Output:
Return code: 1 |
There was an error while creating a SRPM. Output:
Return code: 127 |
There was an error while creating a SRPM. You can re-trigger copr build by adding a comment ( Output:
Return code: 1 |
There was an error while running a copr build: (0) You can re-trigger copr build by adding a comment ( |
There was an error while running a copr build: (0) You can re-trigger copr build by adding a comment ( |
Trying this now locally: I hope I'd be able to get back to you tomorrow morning since I have to leave now. I also ran into this one using packit 0.6.0: packit/packit#524 |
diff --git a/.packit.yaml b/.packit.yaml
index 8ca85d0..a5a876f 100644
--- a/.packit.yaml
+++ b/.packit.yaml
@@ -15,6 +15,4 @@ jobs:
- fedora-29-x86_64
actions:
- create-archive:
- - make tarball
+ create-archive: make tarball
diff --git a/Makefile b/Makefile
index 1ef44bd..31204d1 100644
--- a/Makefile
+++ b/Makefile
@@ -43,7 +43,8 @@ source: clean
mkdir -p $(TMP)/$(PACKAGE)
cp -a $(FILES) $(TMP)/$(PACKAGE)
tarball: source man
- cd $(TMP) && tar cfz SOURCES/$(PACKAGE).tar.gz $(PACKAGE)
+ cd $(TMP) && tar cfz $(PACKAGE).tar.gz $(PACKAGE)
+ mv $(TMP)/$(PACKAGE).tar.gz ../
rpm: tarball
rpmbuild --define '_topdir $(TMP)' -bb fmf.spec
srpm: tarball It should work with this patch. Btw I stumbled upon another bug in packit 0.6.0 packit/packit#526 |
This will not work for me as it breaks other targets (make srpm, make rpm). It's not possible to provide multiple commands to the |
so can you wrap the two commands in a new make target?
Sadly there is bug in create-archive that it can't accept the list of commands now: packit/packit#524 The problem is that we read the path to the archive from stdout, so if it's a list, we don't know where to read it from. |
There was an error while running a copr build: The spec file doesn't have sources set via Source0 |
Darn it, I'll take a look on Monday. |
@TomasTomecek is there any issue with the spec? |
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
It is, actually :D you are not using #59 With these changes I was able to rebuild fmf locally. |
Fix packit configuration
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Hooray! Just one last thing: Moving the tarball breaks "make srpm". Could we modify |
so replace I don't know to be honest: I've never tried to put absolute paths inside a spec file. |
There was an error while running a copr build: Failed to parse SPEC file: error: line 10: Unknown tag: find . -type f -name "*.py[co]" -delete |
/packit copr-build |
There was an error while running a copr build: Failed to parse SPEC file: error: line 10: Unknown tag: find . -type f -name "*.py[co]" -delete |
1 similar comment
There was an error while running a copr build: Failed to parse SPEC file: error: line 10: Unknown tag: find . -type f -name "*.py[co]" -delete |
There was an error while creating a SRPM. You can re-trigger copr build by adding a comment ( Output:
Return code: 1 |
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
Congratulations! The build has finished successfully. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
@TomasTomecek, thanks much for your help! |
my pleasure |
No description provided.