Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable packit #58

Merged
merged 15 commits into from
Sep 17, 2019
Merged

Enable packit #58

merged 15 commits into from
Sep 17, 2019

Conversation

psss
Copy link
Collaborator

@psss psss commented Aug 10, 2019

No description provided.

@coveralls
Copy link

coveralls commented Aug 10, 2019

Pull Request Test Coverage Report for Build 280

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 260: 0.0%
Covered Lines: 533
Relevant Lines: 533

💛 - Coveralls

@packit-as-a-service
Copy link

There was an error while creating a SRPM.

Output:

rm -rf /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp build dist fmf.egg-info .cache .pytest_cache
find . -type f -name "*.py[co]" -delete
find . -type f -name "*,cover" -delete
find . -type d -name "__pycache__" -delete
cd docs && make clean
make[1]: Entering directory '/sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/docs'
rm -rf _build/*
make[1]: Leaving directory '/sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/docs'
rm -f .coverage tags
mkdir -p /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/SOURCES
mkdir -p /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/fmf-0.7
cp -a LICENSE README.rst Makefile fmf.spec setup.py examples fmf bin tests /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/fmf-0.7
cp docs/header.txt /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/man.rst
tail -n+7 README.rst >> /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/man.rst
rst2man /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/man.rst > /sandcastle/docker-io-usercont-sandcastle-20190810-143546888103/tmp/fmf-0.7/fmf.1
/bin/sh: rst2man: command not found
make: *** [Makefile:37: man] Error 127

Return code: 2

@packit-as-a-service
Copy link

There was an error while creating a SRPM.

Output:

/sandcastle/script.sh: line 3: exec: pip: not found

Return code: 127

@packit-as-a-service
Copy link

There was an error while creating a SRPM.

Output:

Failed to set locale, defaulting to C.UTF-8
Error: This command has to be run under the root user.

Return code: 1

@packit-as-a-service
Copy link

There was an error while creating a SRPM.

Output:

The directory '/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting docutils
  Downloading https://files.pythonhosted.org/packages/22/cd/a6aa959dca619918ccb55023b4cb151949c64d4d5d55b3f4ffd7eee0c6e8/docutils-0.15.2-py3-none-any.whl (547kB)
Installing collected packages: docutils
Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/.local'
Check the permissions.


Return code: 1

@packit-as-a-service
Copy link

There was an error while creating a SRPM.

Output:

The directory '/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting docutils
  Downloading https://files.pythonhosted.org/packages/22/cd/a6aa959dca619918ccb55023b4cb151949c64d4d5d55b3f4ffd7eee0c6e8/docutils-0.15.2-py3-none-any.whl (547kB)
Installing collected packages: docutils
Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '/usr/local/lib/python3.7'
Consider using the `--user` option or check the permissions.


Return code: 1

@packit-as-a-service
Copy link

There was an error while creating a SRPM.

Output:

/sandcastle/script.sh: line 3: exec: export: not found

Return code: 127

@packit-as-a-service
Copy link

There was an error while creating a SRPM. You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

Output:

mv: cannot stat 'tmp/fmf*': No such file or directory

Return code: 1

@psss psss changed the title Just testing packit... Enable packit Aug 28, 2019
@packit-as-a-service
Copy link

There was an error while running a copr build: (0)
Reason:

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@packit-as-a-service
Copy link

There was an error while running a copr build: (0)
Reason:

You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@TomasTomecek
Copy link
Contributor

Trying this now locally: I hope I'd be able to get back to you tomorrow morning since I have to leave now.

I also ran into this one using packit 0.6.0: packit/packit#524

@TomasTomecek
Copy link
Contributor

diff --git a/.packit.yaml b/.packit.yaml
index 8ca85d0..a5a876f 100644
--- a/.packit.yaml
+++ b/.packit.yaml
@@ -15,6 +15,4 @@ jobs:
       - fedora-29-x86_64
 
 actions:
-  create-archive:
-    - make tarball
+  create-archive: make tarball
diff --git a/Makefile b/Makefile
index 1ef44bd..31204d1 100644
--- a/Makefile
+++ b/Makefile
@@ -43,7 +43,8 @@ source: clean
        mkdir -p $(TMP)/$(PACKAGE)
        cp -a $(FILES) $(TMP)/$(PACKAGE)
 tarball: source man
-   cd $(TMP) && tar cfz SOURCES/$(PACKAGE).tar.gz $(PACKAGE)
+ cd $(TMP) && tar cfz $(PACKAGE).tar.gz $(PACKAGE)
+ mv $(TMP)/$(PACKAGE).tar.gz ../
 rpm: tarball
        rpmbuild --define '_topdir $(TMP)' -bb fmf.spec
 srpm: tarball

It should work with this patch.

Btw I stumbled upon another bug in packit 0.6.0 packit/packit#526

@psss
Copy link
Collaborator Author

psss commented Sep 12, 2019

This will not work for me as it breaks other targets (make srpm, make rpm). It's not possible to provide multiple commands to the create_archive option? Or you just need to have the tarball stored one level higher in the directory path (as the patch suggests)?

@TomasTomecek
Copy link
Contributor

This will not work for me as it breaks other targets (make srpm, make rpm). It's not possible to provide multiple commands to the create_archive option?

so can you wrap the two commands in a new make target?

Or you just need to have the tarball stored one level higher in the directory path (as the patch suggests)?

Sadly there is bug in create-archive that it can't accept the list of commands now: packit/packit#524 The problem is that we read the path to the archive from stdout, so if it's a list, we don't know where to read it from.

@packit-as-a-service
Copy link

There was an error while running a copr build: The spec file doesn't have sources set via Source0
You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@TomasTomecek
Copy link
Contributor

Darn it, I'll take a look on Monday.

@psss
Copy link
Collaborator Author

psss commented Sep 17, 2019

@TomasTomecek is there any issue with the spec?

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek
Copy link
Contributor

It is, actually :D you are not using Source0 as the primary source. I'll create a packit issue to track this, but I've never seen a spec file which would reference primary archive as Source and not as Source0. But I haven't seen that many spec files.

#59 With these changes I was able to rebuild fmf locally.

@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-fmf-58
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TomasTomecek
Copy link
Contributor

Party time!

@psss
Copy link
Collaborator Author

psss commented Sep 17, 2019

Hooray! Just one last thing: Moving the tarball breaks "make srpm". Could we modify print-tarball-path instead to provide full path?

@TomasTomecek
Copy link
Contributor

so replace make srpm with packit srpm ;)

I don't know to be honest: I've never tried to put absolute paths inside a spec file.

@packit-as-a-service
Copy link

There was an error while running a copr build: Failed to parse SPEC file: error: line 10: Unknown tag: find . -type f -name "*.py[co]" -delete
You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@psss
Copy link
Collaborator Author

psss commented Sep 17, 2019

/packit copr-build

@packit-as-a-service
Copy link

There was an error while running a copr build: Failed to parse SPEC file: error: line 10: Unknown tag: find . -type f -name "*.py[co]" -delete
You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

1 similar comment
@packit-as-a-service
Copy link

There was an error while running a copr build: Failed to parse SPEC file: error: line 10: Unknown tag: find . -type f -name "*.py[co]" -delete
You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

@packit-as-a-service
Copy link

There was an error while creating a SRPM. You can re-trigger copr build by adding a comment (/packit copr-build) into this pull request.

Output:

error: File ./fmf-0.7.tar.gz: No such file or directory

Return code: 1

@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-fmf-58
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@packit-as-a-service
Copy link

Congratulations! The build has finished successfully. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/psss-fmf-58
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@psss psss merged commit 290991e into master Sep 17, 2019
@psss
Copy link
Collaborator Author

psss commented Sep 17, 2019

@TomasTomecek, thanks much for your help!

@psss psss deleted the packit branch September 17, 2019 17:43
@TomasTomecek
Copy link
Contributor

my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants