New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a visual indicator to tabs containing code (issue #1194) #1204

Merged
merged 1 commit into from Jul 15, 2016

Conversation

Projects
None yet
4 participants
@tstenner
Contributor

tstenner commented Jul 11, 2016

FlatNotebook-tabs don't allow styling, so this code adds an asterisk after the tab name if the associated CodeBox isn't empty (see issue #1194).

Example:
2016-07-11-132253_1600x900_scrot-fs8

The titles are only recalculated when opening the dialog, so switching between tabs after editing doesn't add the asterisks. This shouldn't be a problem, as it's mainly needed when opening the code dialog for the first time.

@coveralls

This comment has been minimized.

coveralls commented Jul 11, 2016

Coverage Status

Coverage decreased (-0.004%) to 50.669% when pulling 3e14244 on tstenner:codetabs_indicator into d2a974c on psychopy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 11, 2016

Current coverage is 46.43%

Merging #1204 into master will decrease coverage by 0.01%

@@             master      #1204   diff @@
==========================================
  Files           231        231          
  Lines         36550      36553     +3   
  Methods           0          0          
  Messages          0          0          
  Branches       5639       5640     +1   
==========================================
- Hits          16979      16975     -4   
- Misses        18022      18031     +9   
+ Partials       1549       1547     -2   

Powered by Codecov. Last updated by d2a974c...3e14244

@peircej peircej merged commit 74c88c8 into psychopy:master Jul 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tstenner tstenner deleted the tstenner:codetabs_indicator branch Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment