Merged DotStim fixes (schofiaj) and added audioDevice preference #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update my fork
The bugs are: 1. Dots that go out of bounds are replaced at a random location. When coherence is high this results in a shift in dot density toward the edge where most dots are going out of bounds. When coherence is low it causes a shift way from all borders. This is because the dots are disappearing at edges to keep the distribution of dots uniform they should be reborn at the opposite edge. 2. When noise dots are in walk mode the dot directions are not updated often enough such that as the coherence changes some noise dots become signal dots but retain the ransom direction they had when they were noise. 3. Dot locations are not refreshed between trials. If dot lifetime is long (esp infinite) one can see clusters of dots consistent from trial to trail. This accentuates the bug in (1) when signal dots reverse direction between trials as the accumulated dots on one side of the field then all charge back across the field together. I’ve fixed these by. See dots.py attached
Should be working correctly on pyo, sounddevice and pysoundcard
(but have tested that there are no memory leaks using psychopy.info.getRAM() in a loop)
by not using copy we were actually altering the user's original array
so we have to set the manually immediately after creation
The issues only become apparent on win32 due to limit of 1 stream Also added some extra checks to block sizes during addition of hamming window
Hard for the user to know otherwise what the available options are
The fix by @schofiaj is right in principal but currently means that dots are straying outside the aperture. Will revert to previous behaviour of random location for out-of-bounds dots until we can fix this
It looks like travis is trying to load the pyo lib, which has no anti-travis defenses
On ubuntu it seems that the first frame is requested as part of the init so some of the variables didn't exist yet. Also we had latency set to 'high' for some testing but should obviously be 'low' latency
peircej
commented
Jan 23, 2017
| #wind the dots back one step and store as tempary values | ||
| if self.noiseDots == 'position': |
There was a problem hiding this comment.
@schofiaj For now I've turned off your wrapping fix and reverted to recreating dots with a new random position, due to the issue with dots appearing outside the aperture. Your other fixes remain in place though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.