New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Slider did not respect `color` kwarg #1944

Merged
merged 2 commits into from Aug 15, 2018

Conversation

Projects
None yet
4 participants
@hoechenberger
Member

hoechenberger commented Aug 15, 2018

No description provided.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 15, 2018

Coverage Status

Coverage increased (+0.3%) to 48.447% when pulling 60973ef on hoechenberger:slider into 029a800 on psychopy:master.

coveralls commented Aug 15, 2018

Coverage Status

Coverage increased (+0.3%) to 48.447% when pulling 60973ef on hoechenberger:slider into 029a800 on psychopy:master.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 15, 2018

Codecov Report

Merging #1944 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
+ Coverage   43.88%   44.13%   +0.24%     
==========================================
  Files         207      207              
  Lines       36360    36362       +2     
  Branches     6214     6214              
==========================================
+ Hits        15958    16049      +91     
+ Misses      18853    18749     -104     
- Partials     1549     1564      +15
Impacted Files Coverage Δ
psychopy/visual/slider.py 47.7% <100%> (+31.55%) ⬆️
psychopy/visual/textbox/fontmanager.py 70.03% <0%> (-1.05%) ⬇️
psychopy/visual/basevisual.py 67.12% <0%> (+0.17%) ⬆️
psychopy/visual/elementarray.py 77.92% <0%> (+0.66%) ⬆️
psychopy/data/base.py 72.76% <0%> (+0.89%) ⬆️
psychopy/visual/shape.py 82.81% <0%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029a800...60973ef. Read the comment docs.

codecov-io commented Aug 15, 2018

Codecov Report

Merging #1944 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
+ Coverage   43.88%   44.13%   +0.24%     
==========================================
  Files         207      207              
  Lines       36360    36362       +2     
  Branches     6214     6214              
==========================================
+ Hits        15958    16049      +91     
+ Misses      18853    18749     -104     
- Partials     1549     1564      +15
Impacted Files Coverage Δ
psychopy/visual/slider.py 47.7% <100%> (+31.55%) ⬆️
psychopy/visual/textbox/fontmanager.py 70.03% <0%> (-1.05%) ⬇️
psychopy/visual/basevisual.py 67.12% <0%> (+0.17%) ⬆️
psychopy/visual/elementarray.py 77.92% <0%> (+0.66%) ⬆️
psychopy/data/base.py 72.76% <0%> (+0.89%) ⬆️
psychopy/visual/shape.py 82.81% <0%> (+2.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 029a800...60973ef. Read the comment docs.

@peircej peircej merged commit 06683c4 into psychopy:master Aug 15, 2018

1 of 2 checks passed

LGTM analysis: Python Running analyses for revisions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment