Timing improvements #2557
Merged
Timing improvements #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now providing a default window to sync to (like the when arg in play()) Fixed issue with extra stopping logging items
In the past we were deciding whether to draw for one more frame based on a guess about when the next frame will occur, but not trying to determine how far we are from that flip time: ``` if tDesired > (t-frameInterval*0.5): #guess we switch ``` Window now has a method to estimate time of next flip: ``` timeNextFlip = win.getFutureFlipTime() if tDesired > timeNextFlip-tolerance: #we're more confident based on actual predicted frame time ``` On my tests this has made the stimulus timing very accurate whereas before it was often out by a frame
…ming-improvements # Conflicts: # psychopy/experiment/components/sound/__init__.py # psychopy/sound/backend_ptb.py # psychopy/visual/window.py
Codecov Report
@@ Coverage Diff @@
## master #2557 +/- ##
==========================================
+ Coverage 44.43% 44.45% +0.02%
==========================================
Files 234 234
Lines 41255 41275 +20
Branches 7115 7121 +6
==========================================
+ Hits 18331 18349 +18
- Misses 20966 20970 +4
+ Partials 1958 1956 -2
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert and fixes 1 when merging 12d4781 into 4011fe0 - view on LGTM.com new alerts:
fixed alerts:
This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
Window.getFutureFlipTime(), created for PTB sound timing, we can make more accurate timing decisions for Builder output code as well.