RF: Refactoring the components panel #3673
Conversation
…unt of code and removes unused / outdated functions. Removes collapsible category buttons (possibly temporarily) as these were prone to error and not really worth the trouble, otherwise functions as before but with less code
Codecov Report
@@ Coverage Diff @@
## dev #3673 +/- ##
==========================================
+ Coverage 43.05% 43.54% +0.48%
==========================================
Files 269 274 +5
Lines 53030 53619 +589
Branches 9170 9195 +25
==========================================
+ Hits 22834 23349 +515
- Misses 27876 27921 +45
- Partials 2320 2349 +29
Continue to review full report at Codecov.
|
|
This pull request introduces 3 alerts and fixes 1 when merging c028f48 into 18140ac - view on LGTM.com new alerts:
fixed alerts:
|
…ibutes across different components. Allows tooltip attribute to be used rather than docstrings
|
This pull request introduces 3 alerts and fixes 1 when merging 90c4080 into 18140ac - view on LGTM.com new alerts:
fixed alerts:
|
|
Update: I've reinstated category buttons, but I couldn't include the ᐊ and ᐁ from before. These are unique to plate buttons, but the way we were using plate buttons was kind of hacky - they're intended for context menus, not showing/hiding sizers within a panel. They're also an absolute nightmare to style, you have to find the protected class defining their init colours and change these then call updates on them... Whereas regular buttons can just use SetForegroundColour/SetBackgroundColour. |
|
This pull request introduces 3 alerts and fixes 1 when merging 2053d50 into ae519ab - view on LGTM.com new alerts:
fixed alerts:
|
|
With your changes to the Component structure, I'm guessing that means people's custom Components will break (because they will have their icons etc in the old location?) |
…ss, it will use the UnknownComponent icon rather than crashing
Most recent commit addresses this - they'll need to haveiconFile, targets, tooltip and categories in the class def rather than module def for it to use these rather than the BaseComponent and BaseVisualComponent defaults, but it now won't crash :) Some may have already - before it wasn't consistent what was where |
|
This pull request introduces 3 alerts and fixes 1 when merging d370cfd into 349c99a - view on LGTM.com new alerts:
fixed alerts:
|
Refactor of the components panel to:
Appearance and function are largely unaffected, just three things different:
Button labels aren't wrapping yet, there's nothing about the refactor stopping this I just need to reimplement it stillDone this now!Tooltips need moving to class attributes rather than module attributes, again nothing preventing this I just haven't done it yet, I've used docstrings as a placeholderThis too!I've replaced the panel buttons with static labels, buttons are still in sizers accorded to category so I can add them back in but they were kind of buggy so didn't want to spend time implementing them when labels may be better anyway.Now reinstated, but without arrows.Pulling to dev so this is non-urgent, just wanted to get this in at some point as I'm basing a standaloneRoutines branch off of this refactor to avoid conflicts.