Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bufferline diagnostics_update_in_insert is deprecated #1890

Closed
1 task done
pinarruiz opened this issue Jul 18, 2024 · 0 comments · Fixed by #2013
Closed
1 task done

[BUG] Bufferline diagnostics_update_in_insert is deprecated #1890

pinarruiz opened this issue Jul 18, 2024 · 0 comments · Fixed by #2013
Labels
bug Something isn't working

Comments

@pinarruiz
Copy link
Contributor

Field Description
Plugin Bufferline.nvim
Nixpkgs unstable (ad0b5eed1b6031efaed382844806550c3dcb4206)
  • I have read the FAQ and my bug is not listed there.

Description

When using the bufferline option plugins.bufferline.diagnosticsUpdateInInsert, i get the following error:

diagnostics_update_in_insert is deprecated, use vim.diagnostic.config { update_in_insert = true } instead.
Feature will be removed in bufferline 4.6.3

Minimal, Reproducible Example (MRE)

programs.nixvim.plugins.bufferline = {
  enable = true;
  diagnostics = "nvim_lsp";
  diagnosticsUpdateInInsert = true;
  diagnosticsIndicator = ''
    function(count, level, diagnostics_dict, context)
      local s = " "
      for e, n in pairs(diagnostics_dict) do
        local sym = e == "error" and "󰅚 "
          or (e == "warning" and "󰀪 " or 
            ( e == "hint" and "󰌶 " or "󰋽 ")
          )
        s = s .. n .. sym
      end
      return s
    end
  '';
};

Also, out of scope, might be cool to merge all this bufferline diagnostics options into one.

@pinarruiz pinarruiz added the bug Something isn't working label Jul 18, 2024
khaneliman added a commit to khaneliman/nixvim that referenced this issue Aug 13, 2024
Also resolves nix-community#1890 by
automatically setting up `diagnostics.update_in_insert` for the user.
khaneliman added a commit to khaneliman/nixvim that referenced this issue Aug 13, 2024
Also resolves nix-community#1890 by
automatically setting up `diagnostics.update_in_insert` for the user.
khaneliman added a commit to khaneliman/nixvim that referenced this issue Aug 13, 2024
Also resolves nix-community#1890 by
automatically setting up `diagnostics.update_in_insert` for the user.
khaneliman added a commit to khaneliman/nixvim that referenced this issue Aug 13, 2024
Also resolves nix-community#1890 by
automatically setting up `diagnostics.update_in_insert` for the user.
khaneliman added a commit to khaneliman/nixvim that referenced this issue Aug 13, 2024
Also resolves nix-community#1890 by
automatically setting up `diagnostics.update_in_insert` for the user.
@mergify mergify bot closed this as completed in cb398ce Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant