[WIP, DO NOT MERGE!] Hsiao.googletest2 #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chhsiao1981
force-pushed
the
hsiao.googletest2
branch
6 times, most recently
from
4f9d80e
to
283ef40
Compare
chhsiao1981
force-pushed
the
hsiao.googletest2
branch
from
283ef40
to
fd2b447
Compare
|
Close this PR to prevent accidentally merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reflect the #34 by integrating CMakeLists.txt in mbbsd / common / util as well.
Tested in Mac (with ncurses installed with homebrew as static lib)
and Ubuntu 16.04 (by export CC=/usr/bin/clang and export CXX=/usr/bin/clang++)
The compiling / linking flags are the same as the original Makefile in these 2 platforms.
This PR is intended to used as discussion. I'll have the corresponding modification on #34
after the discussion is finalized.