Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version control (npm) #7

Closed
r1m opened this issue Feb 4, 2016 · 6 comments
Closed

Version control (npm) #7

r1m opened this issue Feb 4, 2016 · 6 comments

Comments

@r1m
Copy link
Contributor

r1m commented Feb 4, 2016

I would be nice to have a package.json with actual version that follows semantic versionning.
And git tags that matches release versions.
It allows a better control on dependencies with npm.

@oliverheilig
Copy link
Member

Yes, you are right. It would be helpful to make it conform to the official plugin authoring guide

https://github.com/Leaflet/Leaflet/blob/master/PLUGIN-GUIDE.md

I will read it

@nmco
Copy link

nmco commented May 17, 2016

Any news on this ? If I understood correctly the current published version in npm is compatible with leaflet master, any chance that this release https://github.com/ptv-logistics/Leaflet.NonTiledLayer/releases/tag/v0.7.3 gets also published in npm ? Thanks for this module :)

@oliverheilig
Copy link
Member

Hi,

didn't find the time to deal with npm publishing yet. Hope i can find the time to add npm publishing next week.

Oliver

@nmco
Copy link

nmco commented May 23, 2016

Very good news thank you :)

@oliverheilig
Copy link
Member

Hi,

i did a test publishing a while ago

https://www.npmjs.com/package/leaflet.nontiledlayer

Now i wanted to test it with this tutorial

http://makerlog.org/posts/leaflet-basics

But browserify/require don't work when just publishing it, at least with Leaflet 1.0. Afaik i need to implement an APM, like explained here

Leaflet/Leaflet#2783

So making it an "official" plugin is still some work.

@oliverheilig
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants