Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In memory, no need to keep derivations when there is a decision #56

Closed
mpizenberg opened this issue Oct 30, 2020 · 1 comment
Closed

Comments

@mpizenberg
Copy link
Member

I realized that while writing the guide. Every usage of memory we have will either do something if there is a decision or something else if there isn't one yet. The only method returning a mix of decision and derivation is assignment_intersection but in fact, if there is a decision, we don't need derivations term, since the intersection will directly be the term of the decision.

So in fact we should have PackageAssignment be an enum instead of a struct. That would imply some changes in the API, and especially some algorithm changes regarding remove_decision that should not be used anymore, but I believe this is doable.

@Eh2406
Copy link
Member

Eh2406 commented Oct 30, 2020

That is a grate point. I think it will clean things up a lot. If it does then I'd be for it even if it is a small performance regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants