Node.js 0.8 compatibility and full async behavior #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm must add that the readme reflect a new version 0.4.2 in case you accept the pull request and publish it to npm, package.json is not yet updated. |
slaskis
added a commit
that referenced
this pull request
Aug 13, 2012
|
I already had the tests rewritten to mocha a while ago actually but never commited them as I started on a rewrite of the library which is more stream-focused but now I added some of your tests as well as 0.8 compatibility. Really appreciated, thanks! |
|
Thanks for your commitment to this project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope those changes will make it through. I use open-uri in mecano and as I started to use Node.js v0.8, I was buzz with the
path.existsSyncbeing renamed. At the same time, I realized that some part of your module was using sync methods. So I took the liberty to update the code and I'm happy to send the changes back to you. Also, I've updated the test to mocha and should because some of your tests were achieving their goal (at a few places, you could negate the condition and no failure will be reported by expresso).Thanks for this module, regards, d.