Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning issue for next major release of LDI #126

Open
jywarren opened this issue Feb 4, 2019 · 9 comments

Comments

Projects
None yet
4 participants
@jywarren
Copy link
Contributor

commented Feb 4, 2019

Coming out of the broader MapKnitter upgrade project, I'm collecting a set of issues/ideas/projects which we'd like to tackle in the next big release.

Projects

  • multiple image selection #29, means to drag multiple or perform actions on image collections
  • simpler menu API to add new tools (even after initialization, like img = new L.DistortableImageOverlay(...); img.addAction(); perhaps? (#141)
  • abstract tools UI from tools functions, allow for alternative tools UIs to be attached instead of default Toolbar (#140)
    • nested menus or modal for more tools, as the menu runs out of space? (also build on #140)
  • image ordering? #84, mapknitter link-in in publiclab/mapknitter#116
  • full res download from menu (#100 but needs a way to pass in full-res original image in options)
    • 'place with geodata' tool, not sure if this lives in MK or LDI, we have a lot of code for it here which could be broken out into a separate file, or even a separate npm module: #142

Needs bug documentation

(need to list out all observed bugs with screenshots/gifs, could ask people to help with this in an issue?)

  • debugging of menu placement, hide/show
  • thorough cross-browser UI testing of toolbar
  • toolbar bugs when you delete images

Compatibility

  • compatibility with React wrapper: #105

Assorted other issues/bugs/ideas here: #87

  • resolve grunt build and karma issue in Travis CI: #122

Assorted utility functions

Dream projects

  • detect similar features in nearby or overlapping images while dragging: #110
@jywarren

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

@gauravano @SidharthBansal starting to build this out a good bit! These are pretty important to the overall project as they focus on the usability and debugging of the UI.

@jywarren

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@rexagod @sashadev-sky I've broken out a number of these into new stand-alone issues with some code links and discussion! Would love to hear your thoughts!

@sashadev-sky

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2019

@jywarren I will take on
"multiple image selection #29, means to drag multiple or perform actions on image collections" if that is okay!

@rexagod

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2019

  • nested menus or modal for more tools, as the menu runs out of space? (also build on #140)

How about displaying a modal with keymaps for all the different functions, while including the more important ones in the toolbar, or even swapping the toolbar icons with the ones that user frequents? Relates to #141, too.

@sashadev-sky

This comment has been minimized.

Copy link
Collaborator

commented Feb 20, 2019

I was thinking about that too! It could be one of the interfaces the developer can select for their sidebar. Also that would be cool to have it auto sort by how frequently they are used.
screen shot 2019-02-20 at 4 46 24 pm

I thought this legends window I saw on an example map was very pleasant looking

@jywarren

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

Oh cool! Yes, and i think i mention the alternative Control (not popup) UI for Leaflet.toolbar in #140, which could help achieve something like this too!

@rexagod

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

@jywarren ⬆️ Please review these whenever you have the time to. I hope the barnraising event went well, the twitterverse was full of it! I checked in every now and then to keep up with the event and it seemed really interesting! I think you all deserve some rest. 😉 👏

@jywarren

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2019

Aww, thanks @rexagod -- i was resting so i missed this! :laugh: Will do now!

@rexagod

This comment has been minimized.

Copy link
Collaborator

commented Mar 30, 2019

Pinging @jywarren to re-open this.

@jywarren jywarren reopened this Mar 30, 2019

@sashadev-sky sashadev-sky referenced this issue Apr 10, 2019

Merged

Toolbar positioning #201

6 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.