Simplify menu API to add tools at runtime #149
Conversation
|
|
There was a problem hiding this comment.
This is really nice. I'll check if you've done this, but was thinking that it's easier to review if we keep the formatting fixes in a single commit so the functional changes can be reviewed without being mixed with the formatting changes, but it was not too hard to sort out. Thanks!
The requests I made were small with one exception - the window.defaults => L.DistortableImage.EditToolbarDefaults change, which I think could work, what do you think?
Fantastic work on this!
|
@sashadev-sky check this out, it's really nice! It also gives us a hint to the implementation of different UIs, in terms of how we structure that. |
|
OK, looks great and I believe ready to merge once rebased! |
|
@jywarren I've rebased this branch. Please review. Thanks! |
|
Great! Super work here. Thanks! |
Fixes #141.