Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition the bar of editing icons at top of composition box #124

Closed
jywarren opened this issue Feb 15, 2018 · 3 comments · Fixed by #203
Closed

Reposition the bar of editing icons at top of composition box #124

jywarren opened this issue Feb 15, 2018 · 3 comments · Fixed by #203
Assignees

Comments

@jywarren
Copy link
Member

(reposting on behalf of @ebarry from publiclab/plots2#2334)

Please describe the problem (or idea)

What problem could this idea solve?

I would like to consider moving the "kitchen sink" bar of editing icons above the text box, currently it is below the text box.

screen shot 2018-02-15 at 12 03 39 pm

I feel there are downsides to having the editing icons below the textbox, namely, that doesn't handle well while scrolling up and down the page, and in cases where the note is long, it's hard to scroll all the way down instead of having it pinned at the top.

The scrolling issue may also be a related but separate issue, in that the /post and /question page should not be "below the fold" on the average desktop display. These pages should not scroll unless someone drags the composition box to be longer. Let me know if i should break this issue out.

What did you expect to see that you didn't?

I would expect to see the editing icons positioned at the top of the text box.

Please show us where to look

https://publiclab.org/questions
https://publiclab.org/post

What's your PublicLab.org username?

This can help us diagnose the issue:

liz

@jywarren
Copy link
Member Author

The scrolling issue may also be a related but separate issue, in that the /post and /question page should not be "below the fold" on the average desktop display. These pages should not scroll unless someone drags the composition box to be longer. Let me know if i should break this issue out.

I think this does need to be its own issue, and I don't quite follow yet! Thanks!

@rexagod
Copy link
Member

rexagod commented Jan 1, 2019

Looks like we aren't the only ones facing this issue.

@jywarren Do you want the btn-group to be in a position:fixed mode in the container (as illustrated below)?

screenshot from 2019-01-01 19-45-19
screenshot from 2019-01-01 19-45-21
screenshot from 2019-01-01 19-45-47

@jywarren
Copy link
Member Author

jywarren commented Jan 2, 2019

Aha! OK, so #127 that Gaurav found does seem like a good solution. What if we came up with a CSS (and maybe JS) solution where the bar is on the bottom of the textarea, but if the bottom of the textarea goes off the screen, the formatting bar gets absolute-positioned and pegged to the bottom edge of the screen?

rexagod added a commit to rexagod/PublicLab.Editor that referenced this issue Jan 4, 2019
@ghost ghost assigned rexagod Jan 4, 2019
@ghost ghost added the in progress label Jan 4, 2019
rexagod added a commit to rexagod/PublicLab.Editor that referenced this issue Jan 4, 2019
rexagod added a commit to rexagod/PublicLab.Editor that referenced this issue Jan 5, 2019
rexagod added a commit to rexagod/PublicLab.Editor that referenced this issue Jan 5, 2019
jywarren pushed a commit that referenced this issue Jan 6, 2019
* PL.Editor #124

* PL.Editor #124 fix

* PL.Editor #124 final

* PL.Editor #124 indent and remove logs

* Delete _SpecRunner.html
@ghost ghost removed the in progress label Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants