Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content area horizontal overflow #378

Closed
5 tasks
VladimirMikulic opened this issue Dec 31, 2019 · 10 comments
Closed
5 tasks

Content area horizontal overflow #378

VladimirMikulic opened this issue Dec 31, 2019 · 10 comments

Comments

@VladimirMikulic
Copy link
Contributor

VladimirMikulic commented Dec 31, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

🔥 Problem

Screenshot_20191231_181905

PublicLab editor is causing problems on tablets and mobile devices.
It makes big horizontal scroll bars and we need to solve this.

That's why we need you :)

🚩 Goal

Screenshot_20191231_183803

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Open the file PublicLab.Editor/dist/PublicLab.Editor.css

  • Line 24, add this code:

.ple-content {
  overflow-x: hidden;
}

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@welcome
Copy link

welcome bot commented Dec 31, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@DevanshCodes
Copy link
Member

Hey, Can I claim this?

@VladimirMikulic
Copy link
Contributor Author

@DevanshCodes of course, please do :)

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020 via email

@VladimirMikulic
Copy link
Contributor Author

I am glad you like it @jywarren.

@cocolin041
Copy link

Is this still open? Did someone PR it?

@rishabhshuklax
Copy link
Member

@VladimirMikulic is this issue still open? Can I claim it?

@VladimirMikulic
Copy link
Contributor Author

@blurry-x-face go on :)

@rishabhshuklax
Copy link
Member

@VladimirMikulic I didn't find any horizontal scroll, was it fixed in any of the recent PRs? Could you confirm that there still is horizontal scroll

@VladimirMikulic
Copy link
Contributor Author

VladimirMikulic commented Feb 5, 2020

True, it has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants