Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated font format in section 3 #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NitinMore7
Copy link

@NitinMore7 NitinMore7 commented Jan 24, 2019

Fixes #251

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Jan 24, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@IgorWilbert
Copy link
Member

IgorWilbert commented Jan 24, 2019

@gauravano may I review this PR? Also, just to confirm, when we are changing just a tag in the HTML, updating examples\index.html is enough or do we have to update javascripts\fixures\index.html and other files too?

Update PublicLab.Editor.css

Update index.html
@rexagod
Copy link
Member

rexagod commented Jan 25, 2019

@IgorWilbert Please do! Also, no, there's no need to update fixtures.

@grvsachdeva
Copy link
Member

@NitinMore7 I just added Fixes #[issue-number] to the PR body and advice you to do so too as it closes the issue automatically on PR merge. Also, try to open PR on uniquely-named feature branch instead of master.

Thanks!

@grvsachdeva
Copy link
Member

Hi @rexagod @IgorWilbert, what do you think about this PR?

@VladimirMikulic
Copy link
Contributor

@gauravano @NitinMore7 what's the current status of this PR?

@jywarren jywarren changed the base branch from master to main June 24, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update font format in section 3
5 participants